Add torch implementation of IfElse #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
ricardoV94
requested changes
Sep 15, 2024
|
|
||
| def ifelse(cond, *true_and_false, n_outs=n_outs): | ||
| if cond: | ||
| return torch.stack(true_and_false[:n_outs]) |
Member
There was a problem hiding this comment.
We don't need to stack, and shouldn't, because outputs can have different dimensions / sizes
Comment on lines
+317
to
+319
| a = scalar("a") | ||
| x = ifelse(a < 0.4, tuple(np.r_[p1_vals, p2_vals]), tuple(np.r_[p2_vals, p1_vals])) | ||
| x_fg = FunctionGraph([a], x) |
Member
There was a problem hiding this comment.
If you want to test twice, to cover the false case, do a case where the multiple outputs are not something that can be stacked (say (pt.zeros((3, 5), pt.ones(2,)).
I would have the other test case return a single output, to test the single output case as well
ricardoV94
approved these changes
Oct 3, 2024
Member
|
Thanks @Ch0ronomato |
Ch0ronomato
added a commit
to Ch0ronomato/pytensor
that referenced
this pull request
Nov 2, 2024
Co-authored-by: Ian Schweer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the IfElse op support in torch (reopened cause i
git screwupmy old branch)Related Issue
Checklist
Type of change