-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clobber pyodide packages with pip packages in freeze #172
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Hood Chatham <[email protected]>
Can you give example values for |
Over in #171 there's a console reproducer with `pyodide-http`... Really any
wheel URL (even if it's the same version as what's in the
pyodide-lock.json) will trigger the condition.
…On Mon, Jan 6, 2025, 04:55 Hood Chatham ***@***.***> wrote:
Can you give example values for pyodide_packages and pip_packages where
the old code was wrong?
—
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRFUKDWVYALABIC2FFD2JJOIVAVCNFSM6AAAAABUSEGLFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZSHA3DIMRZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
["snowballstemmer", set()], | ||
], | ||
) | ||
def test_freeze_lockfile_compat( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a run with just the test vs main(-ish):
https://github.com/bollwyvl/micropip/actions/runs/12726465651/job/35474893463#step:7:315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It looks good to me in general.
@hoodmane Anything you want to comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bollwyvl!
Thanks, folks! 😁
…On Mon, Jan 13, 2025, 04:01 Hood Chatham ***@***.***> wrote:
Merged #172 <#172> into main.
—
Reply to this email directly, view it on GitHub
<#172 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRC2JAVDFMUDE5PBF4T2KOFG5AVCNFSM6AAAAABUSEGLFGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHEYDEMZZGI4DMMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
references
changes
pyodide-lock.json
if they were not overloaded by some pip mechanismtest_freeze_lockfile_compat
over a packagename
and expecteddepeds
, addpytest