Bump default Rust toolchain to nightly-2025-02-01
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
added
the
do not merge
ryanking13
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Thanks @agriyakhetarpal! I think this needs a changelog.
Also, could you run the integration test just in case?
|
Thanks, Gyeongjae. pyodide/pyodide#5249 doesn't pass, so I'll open a separate PR to test this change in Pyodide and mark it as a draft until then. |
agriyakhetarpal
added a commit
to agriyakhetarpal/pyodide
that referenced
this pull request
Feb 19, 2025
3 tasks
agriyakhetarpal
force-pushed
the
bump/nightly-rust-toolchain
branch
from
5e79591 to
5296552
Compare
agriyakhetarpal
changed the title
|
|
|
2025-02-01 passes for all packages locally, but I triggered CI in pyodide/pyodide#5439 as an additional check. |
agriyakhetarpal
removed
the
do not merge
|
Going ahead here as suggested by @hoodmane in pyodide/pyodide#5439 (comment). Thanks for the review! |
agriyakhetarpal
changed the title
nightly-2025-02-01
agriyakhetarpal
added a commit
to agriyakhetarpal/pyodide-build
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
orjsonversion 3.10.13 in #101 requiresrustc1.82 or newer, but we currently use 1.77-nightly (see logs).I have also performed the same update in pyodide/pyodide#5249 in parallel, so if that passes, we should be safe to merge this. I can also open a new PR with the submodule updated to check if that PR doesn't pass.
Update, 23/02/2025: all builds passed in pyodide/pyodide#5439.