Squash alembic migrations #17607
Closed
Squash alembic migrations #17607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
|
The PR is now ready for review, but the first question is: do the benefits outweigh the drawbacks? Benefits:
The changes yield a consistent 13% performance improvement in both CI and local test execution times, saving several seconds per test run. Drawbacks:
|
|
I think this is probably not worth the added complexity. I appreciate you putting the effort in here, it's hard to know if performance improvements are going to pay off in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion is in #17590
The idea is to remove all previous alembic migrations and consolidate them into a single file to improve testing time.
Marked as draft until we know if it's a good idea or not.