Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #680 #681

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixes #680 #681

wants to merge 2 commits into from

Conversation

speco29
Copy link

@speco29 speco29 commented Feb 10, 2025

Added the missing dependency

Added the missing dependency
@martinfleis
Copy link
Member

You don't need to import it. You just need to ensure it is installed.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (3c05758).
Report is 102 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #681     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.8%     
=======================================
  Files         26      40     +14     
  Lines       4328    7208   +2880     
=======================================
+ Hits        4214    7074   +2860     
- Misses       114     134     +20     

see 1 file with indirect coverage changes

@speco29
Copy link
Author

speco29 commented Feb 11, 2025

You don't need to import it. You just need to ensure it is installed.

Should I close this issue then?
but I think having known which library is being used in the examples would be much better.
let me know your thoughts;)

@martinfleis
Copy link
Member

If you want to do something about #680, then add a note somewhere that mapclassify needs to be installed to run the notebooks in the user guide. Do not import it, the linter fails on that.

However, if you install momepy the recommended way from conda-forge, it will pull mapclassify automatically, so I am not sure if this is even worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants