Add distance backend abstraction scaffold for issue #172 https://github.com/pysal/pointpats/issues/172#175
Draft
SidheshwarSarangal wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
- Coverage 72.6% 72.4% -0.2%
=======================================
Files 12 13 +1
Lines 2124 2145 +21
=======================================
+ Hits 1543 1554 +11
- Misses 581 591 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a small distance-backend abstraction to decouple
distance computation from point pattern statistics.
What this does
DistanceBackendinterfaceEuclideanDistanceBackend(no behavior change)PointPatternwithout breaking initializationk()What this does NOT do
This is intended as architectural groundwork for network-constrained
point patterns discussed in #172.
Refs #172