deprecate skyum's algorithm#207
Open
ljwolf wants to merge 9 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
+ Coverage 72.9% 73.8% +0.9%
=======================================
Files 12 12
Lines 2118 2006 -112
=======================================
- Hits 1543 1480 -63
+ Misses 575 526 -49
🚀 New features to boost your workflow:
|
martinfleis
reviewed
Apr 28, 2026
|
|
||
| @singledispatch | ||
| def minimum_bounding_circle(points): | ||
| """ |
Member
There was a problem hiding this comment.
Can we keep some docstring here?
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Member
|
After conflicts are resolved will this be good to merge? |
Member
No, we need the docstring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an API-transparent swap of the skyum algorithm with shapely's
minimum_bounding_circle(). Let's merge this after #206