Make interpreters code async by default #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR would like to make all interpreters run
async
code by default. The current logic is that if theasync
attribute is present and its value is explicitlyfalse
then it goes back tosync
mode, otherwise all code runs just with top-levelawait
available by default.This MR also already showed that while it's trivial at code level to change these expectations, 5 tests had really hard coded different expectations and I am expecting tests in PyScript to have issue too once this is brought in.
The TL;DR of this MR is that it might take a lot of effort to make this fundamental change around our code but it should be duable, given enough time to test all the things are still working and we don't break all our test coverage we had in place before.
/cc @ntoll