Add possibility to display rofi menus as normal windows #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
On GNOME rofi doesn't receive keyboard input as it is not by default a normal window. Since I'm on Wayland I also tried the rofi-wayland package but it failed to launch because rofi on Wayland requires support for the layer shell protocol. Therefore I decided to implement the option inside ani-cli. The user can add the flag --normal-window (alongside --rofi) to pass -normal-window to rofi. I also added the possibility to set the environment variable ANI_CLI_EXTERNAL_MENU_NORMAL_WINDOW to make it happen always.
Checklist
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work-h
help info is up to dateAdditional Testcases