Skip to content

Add type checking. #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ on:

jobs:

run-type-checking:

name: Run tests for type-checking
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: prefix-dev/[email protected]
with:
pixi-version: v0.23.0
cache: true
environments: typing
- run: pixi run typing

run-tests:

name: Run tests for ${{ matrix.os }} on ${{ matrix.environment }}
Expand All @@ -30,7 +44,7 @@ jobs:
- uses: actions/checkout@v4
- uses: prefix-dev/[email protected]
with:
pixi-version: v0.20.1
pixi-version: v0.23.0
cache: true
environments: ${{ matrix.environment }}

Expand Down
12 changes: 0 additions & 12 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,6 @@ repos:
rev: v2.2.6
hooks:
- id: codespell
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v1.10.0'
hooks:
- id: mypy
additional_dependencies: [
attrs>=21.3.0,
click,
pytask>=0.4.5,
types-PyYAML,
types-setuptools
]
pass_filenames: false
- repo: meta
hooks:
- id: check-hooks-apply
Expand Down
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ releases are available on [PyPI](https://pypi.org/project/pytask-r) and
for serialized arguments.
- {pull}`51` reenables testing with different Python versions.
- {pull}`54` updates tests for pytask v0.5.
- {pull}`56` re-add type checking.

## 0.4.1 - 2024-04-20

Expand Down
Loading
Loading