-
Notifications
You must be signed in to change notification settings - Fork 226
Add type annotations #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add type annotations #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands run: ``` pytest tests/ pyannotate --py3 -w pytest_bdd tests git add pytest_bdd tests pre-commit run ```
# Conflicts: # pytest_bdd/parser.py # pytest_bdd/scenario.py
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 95.40% 92.69% -2.72%
==========================================
Files 48 48
Lines 1566 1642 +76
Branches 166 176 +10
==========================================
+ Hits 1494 1522 +28
- Misses 45 82 +37
- Partials 27 38 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type annotations to the codebase, and add a CI step to run mypy (for now we let it fail, as fixing those failures would require even more time)