Fix step function resolution logic #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elchupanebrej
pushed a commit
to elchupanebrej/pytest-bdd-ng
that referenced
this pull request
Jul 24, 2022
elchupanebrej
added a commit
to elchupanebrej/pytest-bdd-ng
that referenced
this pull request
Jul 24, 2022
* Add the possibility to register imported steps * Add test step definition hierarchy overlapping from pytest-dev#544
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 92.46% 95.17% +2.71%
==========================================
Files 49 48 -1
Lines 1685 1680 -5
Branches 208 206 -2
==========================================
+ Hits 1558 1599 +41
+ Misses 90 51 -39
+ Partials 37 30 -7
Continue to review full report at Codecov.
|
... but only one step impl was kept.
Contributor
Author
|
@The-Compiler would you feel like reviewing the part that uses pytest's internals? |
pbarnajc
pushed a commit
to pbarnajc/pytest-bdd
that referenced
this pull request
Jan 31, 2023
Fix step function resolution logic
pbarnajc
pushed a commit
to pbarnajc/pytest-bdd
that referenced
this pull request
Feb 1, 2023
Fix step function resolution logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step function resolution logic has long been broken. The refactor in #534 made this bug more visible, since it treats all step definitions with and without parsers as the same (previously, definitions without parsers had higher priority).
Also, we now require pytest>=6.2 (I needed to use some newer pytest APIs).
Fixes #542.