[PR #13338/0c454979 backport][8.3.x] Fix broken approx when mixing numpy booleans and booleans
#13342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Fix #13047 --------- Co-authored-by: Bruno Oliveira <[email protected]> (cherry picked from commit 0c45497)
6 tasks
nicoddemus
approved these changes
Apr 2, 2025
nicoddemus
deleted the
patchback/backports/8.3.x/0c454979cc2038bc193eb037e80f658a9183641f/pr-13338
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #13338 as merged into main (0c45497).
Description
Fixed an issue in equality checks where
boolandnumpy.bool_types were not handled consistently.This ensures proper handling of native and numpy boolean types. See #13047.
Fix #13047
Checklist
closes #13047to link this PR to the issue.13047.bugfix.rst.AUTHORSin alphabetical order.