Skip to content

Conversation

@asgardik0
Copy link
Contributor

What

Fixed two instances of broken :ref:Talk `` references in CONTRIBUTING.rst

Changes Made

  • Replaced :ref:Talk to developers with proper RST link Talk to developers <https://docs.pytest.org/en/stable/contact.html>_ in the "Fix bugs" section
  • Replaced :ref:Talk to developers with proper RST link Talk to developers <https://docs.pytest.org/en/stable/contact.html>_ in the "Implement features" section

Why

The original reStructuredText :ref: syntax was malformed and not rendering as clickable links, which could confuse new contributors trying to contact the development team. The new links directly point to the pytest contact documentation page.

Result

Now contributors can easily click through to the contact channels page instead of seeing broken references.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 27, 2025
@bluetech
Copy link
Member

The links are not broken, as can be seen here: https://docs.pytest.org/en/stable/contributing.html#fix-bugs. Can you explain where you saw this?

@asgardik0
Copy link
Contributor Author

The links are not broken, as can be seen here: https://docs.pytest.org/en/stable/contributing.html#fix-bugs. Can you explain where you saw this?

The link are broken here: https://github.com/pytest-dev/pytest?tab=contributing-ov-file#fix-bugs and here: https://github.com/pytest-dev/pytest?tab=contributing-ov-file#implement-features
where :ref:Talk <contact> doesn't work.
On my commit I changed the link to this: https://docs.pytest.org/en/stable/contact.html

@bluetech
Copy link
Member

The links are meant for the Sphinx-build docs but I guess CONTRIBUTING.rst specifically is more likely to be read through github which doesn't resolve such references. So I figure we can make an exception for it and merge this. Thanks.

@bluetech bluetech added skip news used on prs to opt out of the changelog requirement backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch and removed backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch labels Nov 29, 2025
@bluetech bluetech enabled auto-merge (squash) November 29, 2025 09:29
@bluetech bluetech merged commit 4d38675 into pytest-dev:main Nov 29, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants