Catch conftest blocking #14018
Open
Catch conftest blocking #14018
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13634
Summary
This PR fixes an issue where attempting to disable a
conftest.pyfile using the-p no:option resulted in an internal assertion failure.conftest.pyfiles are not plugins and cannot be enabled or disabled using-p, but pytest previously accepted such arguments and crashed later during plugin loading with:Pytest now rejects attempts to block a conftest early during argument processing and raises a clear
UsageErrorexplaining that conftest files cannot be disabled via-p.What’s Changed
Added explicit detection for
-p no:<name>where<name>refers to a conftest file (e.g. conftest.py, or a path to a conftest).Introduced an early
UsageErrorwith an actionable message.Updated config test