Skip to content

Conversation

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Aug 19, 2016

Those are both already mentioned in the breaking changes at the top.

@nicoddemus can we get this into 3.0 please? 😉

Those are both already mentioned in the breaking changes at the top.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.015% when pulling 31ede24 on The-Compiler:changelog-duplicates into be9356a on pytest-dev:features.

@nicoddemus
Copy link
Member

The CHANGELOG and docs don't go into the package, so fixes like this and #1819 are welcome at any time, even after the package has been released.

Having said that, I would not rather go into another cycle of merging/packaging/testing unless there's a code change. The only downside is that this fix will not be included into the actual tag, but I don't think that matters much: after all, you could have noticed that 1 hour or so after the package was released anyway. What do you think?

@The-Compiler
Copy link
Member Author

The-Compiler commented Aug 19, 2016

According to MANIFEST.in the changelog is in the package though, no?

But I'm also okay with the fix not being in as it's a relatively minor thing.

@nicoddemus
Copy link
Member

According to MANIFEST.in the changelog is in the package though, no?

Good point.

But I'm also okay with the fix not being in as it's a relatively minor thing.

I agree. 😁

@nicoddemus nicoddemus merged commit b85a3b0 into pytest-dev:features Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants