scarb & snforge upgrade #2570
Open
scarb & snforge upgrade #2570
+644
−515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iossocket is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks good! Can you please fix the CI issues? I think you need to bump the rust toolchain version in |
|
@Riateche Thanks for your reviewing, have updated the pr, looks like the CI would not be triggered automatically, pending review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are working on a lending protocol that integrates pyth on Starknet and would like to use the latest versions of snforge and scarb.
Rationale
Getting conflicts when using the latest scarb.
How has this been tested?
No logic change, update the dependencies(openzeppelin, snforge_std), change some syntax in unit tests caused by snforge break changes.