Skip to content

Conversation

@taiyangc
Copy link

Updated function parameters to use comments instead of names.

Summary

To import and use MockPyth.sol, the Solidity compiler generates this warning which cannot be easily suppressed from the top:

Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
  --> node_modules/@pythnetwork/pyth-sdk-solidity/MockPyth.sol:95:9:
   |
95 |         bool checkUpdateDataIsMinimal,
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
  --> node_modules/@pythnetwork/pyth-sdk-solidity/MockPyth.sol:96:9:
   |
96 |         bool storeUpdatesIfFresh
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

Rationale

This is an annoyance to users of the pyth solidity sdk

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Updated function parameters to use comments instead of names.
@vercel
Copy link

vercel bot commented Nov 26, 2025

@taiyangc is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant