feat(hip-3-pusher): improved metrics #3243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
29
to
31
| # labels: dex, status, error_reason | ||
| self.update_attempts_total = self.meter.create_counter( | ||
| name="hip_3_relayer_update_attempts_total", |
Contributor
There was a problem hiding this comment.
This should have a symbol label too so we can isolate issues with particular feeds
Comment on lines
203
to
213
| def _get_error_reason(self, response): | ||
| response = response.get("response") | ||
| if not response: | ||
| return None | ||
| elif "Oracle price update too often" in response: | ||
| return "rate_limit" | ||
| elif "Too many cumulative requests" in response: | ||
| return "user_limit" | ||
| else: | ||
| logger.warning("Unrecognized error response: {}", response) | ||
| return "unknown" |
Contributor
There was a problem hiding this comment.
Would be nice to turn the output here into an enum so that we don't have to check against string values in other parts of the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metrics to bring more in line with price-pusher and set up dashboard: http://grafana.monster-vibes.ts.net/d/ef54niixonta8c/hip-3-relayer?orgId=1
Rationale
Observability.
How has this been tested?