Add type-hints to Runner #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
type-hint-runner
branch
2 times, most recently
from
95cc29b to
50143e5
Compare
basnijholt
force-pushed
the
type-hint-runner
branch
from
50143e5 to
d8d77fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 77.88% 77.94% +0.05%
==========================================
Files 37 37
Lines 5508 5526 +18
Branches 989 989
==========================================
+ Hits 4290 4307 +17
- Misses 1066 1067 +1
Partials 152 152
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
basnijholt
force-pushed
the
type-hint-runner
branch
from
b559f5f to
22e2df9
Compare
basnijholt
force-pushed
the
type-hint-runner
branch
from
3a7218a to
cb77432
Compare
7 tasks
basnijholt
added a commit
that referenced
this pull request
Dec 2, 2022
* Add type-annotations to Runner * Add more type-hints * Redo typing of ExecutorTypes and FutureTypes * move around functions * do not import from _asyncio
basnijholt
added a commit
that referenced
this pull request
Apr 7, 2023
* Add type-annotations to Runner * Add more type-hints * Redo typing of ExecutorTypes and FutureTypes * move around functions * do not import from _asyncio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which (if so) issue is fixed.
Fixes #(ISSUE_NUMBER_HERE)
Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).