Skip to content

Limit issue body to 500 characters #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwzrd merged 2 commits into from
Oct 7, 2020
Merged

Limit issue body to 500 characters #488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f02c61
Limit issue body to 500 characters
quanta-kt Oct 6, 2020
8645da6
Use 3 dots for ellipsis
quanta-kt Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bot/exts/halloween/hacktober-issue-finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def format_embed(issue: Dict) -> discord.Embed:
labels = [label["name"] for label in issue["labels"]]

embed = discord.Embed(title=title)
embed.description = body
embed.description = body[:500] + '....' if len(body) > 500 else body
Copy link
Contributor

@Akarys42 Akarys42 Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m being very picky, but would it be possible to use only 3 dots here? That’s what we usually use.

Suggested change
embed.description = body[:500] + '....' if len(body) > 500 else body
embed.description = body[:500] + '...' if len(body) > 500 else body

Copy link
Member

@Den4200 Den4200 Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just use textwrap.shorten instead.

embed.add_field(name="labels", value="\n".join(labels))
embed.url = issue_url
embed.set_footer(text=issue_url)
Expand Down