Remove variable declaration from for-loop header and enclose in block #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves `error: for loop initial declarations are only allowed in C99 mode` when building on gcc 4.4.7 (Default gcc on CentOS 6.x)
|
@jamestryan Any chance you could take a look at this? |
|
I applied the PR in https://github.com/sqlobject/oursql in master and in branch py3k. Seems to be working. Thank you! |
This was referenced Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves
error: for loop initial declarations are only allowed in C99 modewhen building on gcc 4.4.7 (Default gcc on CentOS 6.x) against the MySQL 5.7 libs.This PR has two commits, the first commit only alters indentation because this appears to have accidentally been indented with 3 spaces instead of 4, so it was messing with my editor.
The important portion of the diff is in the second commit: 9ffee5d
See also: #4 which introduced 5.7 support.