Fix Issue #906: Resolve Interval.in_words() incompatibility with Python native datetime.datetime.
#921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Closes #906
Description
This pull request fixes #906, where the Interval.in_words() method produced inconsistent output when using native Python datetime objects.
Solution
In calendars variable with native Python, delta attributes such as
self._delta.hoursare not calculated correctly. These kind of functions have been re-codded to usetotal_seconds()instead. Now, theInterval.in_words()function works correctly with Python’s nativedatetime.datetime.Example
Before PR's Edit:
After PR's Edit: