-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Run streamlit-folium tests as part of our CI #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
name: Run Streamlit Folium Tests | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
run: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout Folium | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup Micromamba env | ||
uses: mamba-org/setup-micromamba@v2 | ||
with: | ||
environment-name: TEST | ||
create-args: >- | ||
python=3 | ||
--file requirements.txt | ||
|
||
- name: Checkout Streamlit Folium | ||
uses: actions/checkout@v4 | ||
with: | ||
repository: randyzwitch/streamlit-folium | ||
ref: master | ||
path: streamlit_folium # Checkout into a subdirectory | ||
|
||
- name: Install streamlit_folium dev dependencies | ||
run: | | ||
pip install -r streamlit_folium/tests/requirements.txt | ||
|
||
- name: Install folium from source | ||
shell: bash -l {0} | ||
run: | | ||
python -m pip install -e . --no-deps --force-reinstall | ||
|
||
- name: Install playwright dependencies | ||
run: | | ||
playwright install --with-deps | ||
|
||
- name: Install annotate-failures-plugin | ||
run: pip install pytest-github-actions-annotate-failures | ||
|
||
- name: Test with pytest and retry flaky tests up to 3 times | ||
run: | | ||
cd streamlit_folium | ||
pip install streamlit-folium | ||
pytest tests/test_frontend.py --browser chromium -s --reruns 3 --junit-xml=test-results.xml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This installs the latest release from Pypi. While the tests we run are 'local' and from their main branch. Maybe that can lead to issues if their master branch has new tests that don't work on the latest release. Maybe it's safer to install the local version with
pip install -e
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something else is I would put installing the package in its own step, now it's together with actually running the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make a difference? I don't know much about best practices for the github CI/CD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know it doesn't make a functional difference, just makes it easier to read and follow.