Upgrade Leaflet from 1.9.3 to 1.9.4 - #2274
Open
nina-mir wants to merge 1 commit into
Open
Conversation
1.9.3's _addFocusListenersOnLayer calls layer.getElement() unguarded, so any GeoJSON layer containing a nested FeatureGroup throws "t.getElement is not a function". 1.9.4 guards the call. This also restores verify_js_logs() in the MultiPoint tooltip test, which had to omit it for that reason. Because the driver fixture is session-scoped, the unread error stayed in the browser log and surfaced in whichever later test read it first — which is why test_notebook[coordinate_ordering.md] has been failing on main despite having no tooltips of its own.
nina-mir
marked this pull request as ready for review
August 27, 2026 07:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #2263 (comment).
Bumps the pinned Leaflet 1.9.3 → 1.9.4, and restores the
verify_js_logs()call intests/selenium/test_multipoints_tooltip_selenium.pythat #2263 had to omit.1.9.4 guards the unchecked
layer.getElement()in_addFocusListenersOnLayer(Tooltip.js:396): Leaflet/Leaflet@v1.9.3...v1.9.4The failing test is
test_notebook[coordinate_ordering.md], but the error doesn't originate there since that page has no tooltips, and in 1.9.3 onlyTooltip.jscallsgetElement(), from the focus-listener path that runs only when a tooltip is bound. It's the MultiPoint test from #2263 that throws. Because that test skippedverify_js_logs(), the uncaught error stayed in the session-scoped driver's console log and surfaced in whichever later test read it first.Worth noting for future selenium tests in this repo: skipping
verify_js_logs()doesn't contain an error locally, it defers it to another test.Reproducible on
main:coordinate_orderingpasses alone and fails when run after the MultiPoint test.Locally on 1.9.4:
tests/selenium76 passed, 1 xfailed — including the heatmappixel-diff test, so no rendering changes.