gh-131885: Document that dict.setdefault takes no keyword arguments #128208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running
```python
{}.setdefault("a", default=1)
```
gives:
```
TypeError: dict.setdefault() takes no keyword arguments
```
bedevere-app
bot
added
docs
|
Related: #128207 |
ZeroIntensity
added
needs backport to 3.12
@ZeroIntensity I have now done that |
picnixz
changed the title
picnixz
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
We could argue that this would violate the Mapping contract and that we have a "bug". Yes it violates the contract, however, the EB has decided that this should be the guidelines (see also #129669 (comment)), so this specific change should not be blocked.
5 tasks
|
Thanks @adamtheturtle for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 30, 2025
…no keyword arguments (pythonGH-128208) (cherry picked from commit edfbd8c) Co-authored-by: Adam Dangoor <[email protected]>
|
GH-131893 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 30, 2025
…no keyword arguments (pythonGH-128208) (cherry picked from commit edfbd8c) Co-authored-by: Adam Dangoor <[email protected]>
|
GH-131894 is a backport of this pull request to the 3.12 branch. |
|
Thank you for the fix! |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…no keyword arguments (python#128208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
{}.setdefault("a", default=1)gives:
*and/as needed #131885📚 Documentation preview 📚: https://cpython-previews--128208.org.readthedocs.build/en/128208/library/stdtypes.html#dict.setdefault