-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
gh-129667: Update annotation in documentation #129669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3dd34eb
da0750d
ec2398f
f2f86ab
ab580de
c24d1a1
f576ea5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,7 +112,7 @@ Interactive Interpreter Objects | |
with it. | ||
|
||
|
||
.. method:: InteractiveInterpreter.showsyntaxerror(filename=None) | ||
.. method:: InteractiveInterpreter.showsyntaxerror(filename=None, **kwargs) | ||
|
||
Display the syntax error that just occurred. This does not display a stack | ||
trace because there isn't one for syntax errors. If *filename* is given, it is | ||
|
@@ -166,7 +166,7 @@ interpreter objects as well as the following additions. | |
Print an exit message when exiting. | ||
|
||
|
||
.. method:: InteractiveConsole.push(line) | ||
.. method:: InteractiveConsole.push(line, filename=None, _symbol="single") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should have a separate PR for re-documenting Finally, |
||
|
||
Push a line of source text to the interpreter. The line should not have a | ||
trailing newline; it may have internal newlines. The line is appended to a | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,7 +147,7 @@ And:: | |
executor.submit(wait_on_future) | ||
|
||
|
||
.. class:: ThreadPoolExecutor(max_workers=None, thread_name_prefix='', initializer=None, initargs=()) | ||
.. class:: ThreadPoolExecutor(max_workers=None, thread_name_prefix='', initializer=None, initargs=(), **ctxkwargs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't ctxkwargs be documented as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a description and found PR #124548 where this argument was added There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As it's 3.14+, this means that this should not be backported. So a separate PR is easier to handle as well. And we can make it part of gh-124694 instead. |
||
|
||
An :class:`Executor` subclass that uses a pool of at most *max_workers* | ||
threads to execute calls asynchronously. | ||
|
@@ -194,6 +194,10 @@ And:: | |
Default value of *max_workers* is changed to | ||
``min(32, (os.process_cpu_count() or 1) + 4)``. | ||
|
||
.. versionchanged:: next | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not "next" as this was added in a previous release (just find the major.minor version where it was added, I think it's still 3.14) |
||
Added *ctxkwargs* to pass additional arguments to ``cls.prepare_context`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's |
||
class method. | ||
|
||
|
||
.. _threadpoolexecutor-example: | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what kwargs means here so I would appreciate that it's documented in a separate PR as well.