gh-129534: Fix asksaveasfilename not appending file extension when none is provided #129682
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
terryjreedy
changed the title
|
PRs for an issue need the issue number, as I added it, to properly link the 2. Note new link at the bottom of the opening message of each. Don't worry about a possible news entry. The failed Ubuntu runs are currently flakey, so I assumed not related to PR and just re-ran them. EDIT: rerun failed in build step, so likely nothing to be done here. |
Lib/tkinter/filedialog.py
Outdated
| if "defaultextension" not in options: | ||
| filetypes = options.get("filetypes") | ||
| if filetypes: | ||
| first_ext = filetypes[0][1] # Get "*.txt" from ("Text files", "*.txt") | ||
| if first_ext.startswith("*"): | ||
| options["defaultextension"] = first_ext[1:] # ".txt" |
There was a problem hiding this comment.
This will work incorrectly in cases like "-.txt" or "*.a[0-9]". It is easier to just specify an unambiguous defaultextension argument in your code.
This change also removes possibility to enter extensionless name, which may be desirable.
Lib/tkinter/filedialog.py
Outdated
| if filename and '.' not in filename: | ||
| ext = options.get("defaultextension", "") | ||
| if ext and not filename.endswith(ext): | ||
| filename += ext |
There was a problem hiding this comment.
This will not work for "hidden" dot-files, for file names containing a dot in the middle by accident, for relative file paths containing "../" or "./". It is easier to add an extension in your program after returning from asksaveasfilename(), in a way that specific to your program.
There was a problem hiding this comment.
Hi @serhiy-storchaka,
Thank you for the feedback!
I’ve updated the implementation to fully address the concerns:
Special extensions like "*.a[0-9]" are no longer auto-set as defaultextension.
Users can now explicitly save files without an extension if they choose.
Hidden files (".env", ".gitignore") and filenames with embedded dots ("file.v1.final") are now handled correctly.
Relative paths ("../file", "./config") and absolute paths are no longer modified.
Let me know if there are any other edge cases I may have missed!
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Issue is closed. |
This PR fixes an issue in tkinter.filedialog.asksaveasfilename where the selected file extension is not appended unless a defaultextension is explicitly set.
Changes Made:
If the user does not provide a file extension, the function now correctly appends the first available extension from filetypes, even if defaultextension is not set.
Ensured better consistency when saving files through the dialog.
Testing Done:
Manually tested with different file types (.txt, .csv, .xlsx, .parquet).
Verified that the correct extension is appended if none is provided by the user.
This fix improves the usability of tkinter.filedialog and aligns its behavior with user expectations. Let me know if further refinements are needed!