gh-135166: fix exception type capture in test.test_zstd #135167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @emmatyping |
|
Looks like the error was changed in #133921 |
|
Thanks @hongweipeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 5, 2025
…nGH-135167) (cherry picked from commit 1b55e12) Co-authored-by: Weipeng Hong <[email protected]>
|
GH-135189 is a backport of this pull request to the 3.14 branch. |
|
Thanks for saving me the trouble of diagnosing this myself! I assume it needs to be in 3.14 too? |
zooba
pushed a commit
that referenced
this pull request
Jun 5, 2025
…35167) gh-135166: Fix exception type expected by test.test_zstd (GH-135167) (cherry picked from commit 1b55e12) Co-authored-by: Weipeng Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.