gh-133438: Fix the use of the terms "argument" and "parameter" in error messages for invalid function calls #135172
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is yet one error message left (for arguments for positional-only parameters passed by keyword), but it is more significant change and I want to discuss it separately. |
serhiy-storchaka
changed the title
…in error messages for invalid function calls
serhiy-storchaka
force-pushed
the
errors-argument-vs-parameter
branch
from
68ec454 to
e19eb6f
Compare
vstinner
reviewed
Jun 6, 2025
| @@ -1318,7 +1318,7 @@ missing_arguments(PyThreadState *tstate, PyCodeObject *co, | |||
| Py_ssize_t i, j = 0; | |||
| Py_ssize_t start, end; | |||
| int positional = (defcount != -1); | |||
| const char *kind = positional ? "positional" : "keyword-only"; | |||
| const char *kind = positional ? "positional" : "keyword"; | |||
There was a problem hiding this comment.
Why not keeping keyword-only here, it's correct, no?
>>> def f(*, x): pass
...
>>> f()
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
f()
~^^
TypeError: f() missing 1 required keyword-only argument: 'x'
There was a problem hiding this comment.
"Keyword-only" is a qualifier of a parameter. Arguments can be "positional" or "keyword".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.