gh-140950: Reset shlex state in push_source() so post-EOF pushes are read#150172
Open
LeSingh1 wants to merge 1 commit into
Open
gh-140950: Reset shlex state in push_source() so post-EOF pushes are read#150172LeSingh1 wants to merge 1 commit into
LeSingh1 wants to merge 1 commit into
Conversation
…s are read After get_token() reaches end of input it sets self.state to None. A subsequent push_source() did not reset state, so the next get_token() call returned EOF immediately and the newly pushed source was silently ignored. pop_source() already resets state to ' ' for the same reason; do the same in push_source().
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-140950.
After
shlex.shlex.get_token()reaches end of input it setsself.statetoNone. A subsequentpush_source()did not reset that state, so the nextget_token()call returned EOF immediately and the newly pushed source was silently ignored.pop_source()already resetsstateto' 'for the same reason. This change does the same inpush_source(), which is the minimal symmetric fix.Reproducer from the issue:
Push during an active stream is unaffected because
stateis already' 'in that case. A regression test is added inLib/test/test_shlex.pyand a Library news entry is added underMisc/NEWS.d/next/Library/.