Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on building for Emscripten #1533

Merged
merged 8 commits into from
Mar 26, 2025
Merged

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Mar 20, 2025

Heavily copied from Brett's WASI guide.


📚 Documentation preview 📚: https://cpython-devguide--1533.org.readthedocs.build/getting-started/setup-building/#emscripten

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham
Heavily copied from Brett's WASI guide.
@hoodmane hoodmane requested review from brettcannon and hugovk March 20, 2025 10:02

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham
@brettcannon
Copy link
Member

Do note that I didn't add the WASI docs until WASI explicitly reached tier 2. I don't know if we have a defined policy around this, though, beyond me just wanting to personally wait until I reached the tier 2 milestone.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hoodmane
Copy link
Contributor Author

Thanks for the edits @hugovk!

hoodmane and others added 3 commits March 24, 2025 10:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham

Verified

This commit was signed with the committer’s verified signature.
hoodmane Hood Chatham
@hoodmane
Copy link
Contributor Author

@hugovk I think this is ready to merge?

@hugovk
Copy link
Member

hugovk commented Mar 26, 2025

Yes, let's merge, we can make future edits as needed. Thank you!

@hugovk hugovk merged commit 9c257f9 into python:main Mar 26, 2025
4 checks passed
@hoodmane hoodmane deleted the emscripten-build branch March 26, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants