Extend contextmanager to asynccontextmanager #11352
Merged
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I cannot press "approve workflows". |
|
Anything else needed? |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Closes python#9922 ### Description Extending the existing special case for `contextlib.contextmanager` to `contextlib.asynccontextmanager`. When used with `TypeVar` gives much better type. ## Test Plan I hope I have included the unit test you need. My minimal reproduction is: ``` from contextlib import asynccontextmanager from typing import AsyncGenerator, Type, TypeVar R = TypeVar("R") @asynccontextmanager async def foo( cls: Type[R], ) -> AsyncGenerator[R, None]: yield cls() async def bar() -> int: async with foo(int) as foo_int: return ( foo_int # error: Incompatible return value type (got "R", expected "int") ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9922
Description
Extending the existing special case for
contextlib.contextmanagertocontextlib.asynccontextmanager. When used withTypeVargives much better type.Test Plan
I hope I have included the unit test you need. My minimal reproduction is: