Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check plugin-generated functions #16524
base: master
Are you sure you want to change the base?
Don't check plugin-generated functions #16524
Changes from 4 commits
a9a83bb
0b7aee9
8a44796
6d92891
525280b
6447d48
33d06cc
8980c84
fcd3e0a
993ac57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also test with
--disallow-any-explicit --disallow-any-decorated
, which were used in #16454?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test for the attrs "regression".
I didn't actually add a regression test for #16454, perhaps I should.
I remember I tried at first, and it was made tricky due
--disallow-any-explicit --disallow-any-decorated
flagging errors in the typeshed fixtures. We normally exclude errors in the typeshed from mypy's output, and this should apparently be fixed for test fixtures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The easiest workaround might be to just
# type: ignore
the fixtures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about 33d06cc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm a little worried about it (see my comment). If there is no other way, it's fine to omit the test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow.
testDisallowUntypedDefsAttrsNoAnnotations
is a "casualty" of this change. I can definitely add--disallow-any-explicit --disallow-any-decorated
to the flags in this test and it still passes. I'm just concerned that it'll muddy the test, by confusing the reader about what I'm testing, i.e. it'll be akin to adding--strict-equality
to the flags. Yes, it still passes, but it's not what's under test.