-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix typing of reversed #10655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix typing of reversed #10655
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0dfbde9
Fix typing of reversed
plokmijnuhby b0e754f
Ignore errors
plokmijnuhby 406c07b
Replace self with cls
plokmijnuhby 64cbf71
Create test_reversed.py
plokmijnuhby 2abadcb
Rename test_reversed.py to check_reversed.py
plokmijnuhby 884d429
Update check_reversed.py
plokmijnuhby e475f46
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 79e15c9
Add more checks
plokmijnuhby 2aa3d06
Fix a typo
plokmijnuhby d2d5318
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 662d99c
Correct name of typevar
plokmijnuhby f717387
Replace iterable with reversible
plokmijnuhby 2521747
Fix myreversible class
plokmijnuhby e7a86d7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b965611
Put list[..] in quotes
plokmijnuhby a5c06b3
Add annotation to __len__
plokmijnuhby 593e7df
Update test_cases/stdlib/builtins/check_reversed.py
JelleZijlstra d42f199
Merge branch 'main' into patch-2
JelleZijlstra eb66889
Update test_cases/stdlib/builtins/check_reversed.py
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Iterator | ||
from typing import Generic, TypeVar | ||
from typing_extensions import assert_type | ||
|
||
x: list[int] = [] | ||
assert_type(list(reversed(x)), "list[int]") | ||
|
||
|
||
class MyReversible: | ||
def __iter__(self) -> Iterator[str]: | ||
yield "blah" | ||
|
||
def __reversed__(self) -> Iterator[str]: | ||
yield "blah" | ||
|
||
|
||
assert_type(list(reversed(MyReversible())), "list[str]") | ||
|
||
|
||
_T = TypeVar("_T") | ||
|
||
|
||
class MyLenAndGetItem(Generic[_T]): | ||
def __len__(self) -> int: | ||
return 0 | ||
|
||
def __getitem__(self, item: int) -> _T: | ||
raise KeyError | ||
|
||
|
||
len_and_get_item: MyLenAndGetItem[int] = MyLenAndGetItem() | ||
assert_type(list(reversed(len_and_get_item)), "list[int]") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.