Make signal
global enum constants annotated as literals
#13336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from regular rewrites of annotations from
GLOBAL: EnumClassName
toGLOBAL: Literal[EnumClassName.MEMBER]
, you may notice a small different kind of change:The reason why I did is because this unifies the outcomes across pyright and mypy (
reveal_type(SIG_BLOCK)
for oldSIG_BLOCK
isSigmasks
according to mypy andLiteral[Sigmasks.SIG_BLOCK]
according to pyright) -- with the new version, both checkers see literal types.