Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rmsnorm lowering #3440

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: rmsnorm lowering #3440

wants to merge 4 commits into from
+261 −5

Conversation

bowang007
Copy link
Collaborator

RMSNORM lowering pass

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 12, 2025
@github-actions github-actions bot requested a review from gs-olive March 12, 2025 18:05
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@github-actions github-actions bot added component: conversion Issues re: Conversion stage and removed component: lowering Issues re: The lowering / preprocessing passes labels Apr 10, 2025
@bowang007 bowang007 marked this pull request as ready for review April 10, 2025 23:25
@bowang007 bowang007 requested review from peri044 and zewenli98 and removed request for gs-olive April 10, 2025 23:26
zewenli98
zewenli98 reviewed Apr 11, 2025
View reviewed changes
py/torch_tensorrt/dynamo/conversion/plugins/_generate_plugin.py
shape_calc_fns = [None] * output.ndim

for i in range(output.ndim):
input_node_expr = input_node_expr = list(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here?

py/torch_tensorrt/dynamo/conversion/plugins/_generate_plugin.py
shape_calc_fns = [None] * args[0].ndim
for i in range(args[0].ndim):
input_node_expr = [syms_arg[i].node.expr for syms_arg in syms_args]
shape_calc_fns = [None] * output.ndim
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like fake_mode above was defined twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@zewenli98 zewenli98 zewenli98 left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bowang007 @narendasan @zewenli98 @facebook-github-bot