-
Notifications
You must be signed in to change notification settings - Fork 362
fix: support masked_scatter by lowering path and corner case of maske… #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6be3e7
to
bb3ff16
Compare
# 6) Reshape the result to match the original broadcasted shape | ||
return replaced.view(input_b.shape) | ||
|
||
|
||
def get_decompositions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chohk88 the implementation looks perfect as such.
Just a slight detail I was wondering. Torch mentions that it supports broadcasting between mask and self tensor, but I see this example working too, basically broadcasting between source and mask. is this supported?
input = torch.zeros(3, 3)
mask = torch.tensor([[1, 0, 1], [0, 0, 1], [0, 0, 0]], dtype=torch.bool)
source = torch.tensor([2, 3, 4])
out = input.masked_scatter_(mask, source)
print("out is", out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apbose, great question! I checked PyTorch’s behavior and it:
- Broadcasts only input and mask (not source)
- Flattens source as-is
- Uses only the first mask.sum() elements of source, ignoring any extras
For example, with source=[2,3,4,5] and three True mask positions, PyTorch applies [2,3,4] and drops the 5 without error.
Our current decomposition does exactly that (broadcasts input/mask, flattens source, then cumsum→gather→where), so no code changes are needed. Let me know if you spot any other edge cases!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! Thanks for the detailed explanation
No ciflow labels are configured for this repo. |
Description
Implemented support for
masked_scatter
in the lowering path, referring to this implementation in PyTorch Inductor.Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: