Skip to content

fix: l2_limit_for_tiling #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: l2_limit_for_tiling #3479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,10 @@ def _populate_trt_builder_config(
self.compilation_settings.tiling_optimization_level
]

builder_config.l2_limit_for_tiling = (
self.compilation_settings.l2_limit_for_tiling
)
if self.compilation_settings.l2_limit_for_tiling != -1:
builder_config.l2_limit_for_tiling = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default value be -1 ? The change LGTM though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. Actually I also checked this but unfortunately I didn't find a default value on the doc page. The only place I can find is trtexec's manual:

--l2LimitForTiling                 Set the L2 cache usage limit for tiling optimization(default is -1)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peri044 Do you have suggestions on the default value?

self.compilation_settings.l2_limit_for_tiling
)

return builder_config

Expand Down
Loading