mx cleanup [1/x]: unbreak mx_formats tests #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1569
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 17e7e77 with merge base 860da26 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Jan 15, 2025
Summary: There tests are: 1. not all passing locally, due to excessive recompiles 2. mostly not running in CI (case by case) This PR fixes (1). A future PR will improve on (2). Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e21b656e09297f12239be4255832c59672236dc3 ghstack-comment-id: 2593881934 Pull Request resolved: #1569
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
drisspg
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There tests are:
This PR fixes (1). A future PR will improve on (2).
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: