Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate float8 tensor subclass #1636

Draft
wants to merge 1 commit into
base: gh/jainapurva/4/base
Choose a base branch
from

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Jan 29, 2025

Float8Tensor, a new subclass for float8, independent of AQT. It's a BC breaking change, hence will need to proceed with it, by deprecating the current API, and issuing a user warning about the deprecation. The new API will be available to users for use. After a substancial amount of time, once we know user has replaced the deprecated API with the updated one, we can delete it's code

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]
@jainapurva jainapurva mentioned this pull request Jan 29, 2025
Copy link

pytorch-bot bot commented Jan 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1636

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 2 Unrelated Failures

As of commit 6af2da8 with merge base abd41e5 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jainapurva added a commit that referenced this pull request Jan 29, 2025
ghstack-source-id: 140144dda9c2cef71256e30caba73d2efa08e0cb
Pull Request resolved: #1636
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is BC-breaking, it would be great to see a more thorough writeup in the PR summary of why we want this and how this fits into the overall strategy of torchao.

@jainapurva
Copy link
Contributor Author

Since this is BC-breaking, it would be great to see a more thorough writeup in the PR summary of why we want this and how this fits into the overall strategy of torchao.

Yes, this PR is still a work in progress. Will add a thorough write-up

@jainapurva jainapurva marked this pull request as draft January 30, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants