-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate float8 tensor subclass #1636
base: gh/jainapurva/4/base
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1636
Note: Links to docs will display an error until the docs builds have been completed. ❌ 12 New Failures, 2 Unrelated FailuresAs of commit 6af2da8 with merge base abd41e5 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 140144dda9c2cef71256e30caba73d2efa08e0cb Pull Request resolved: #1636
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is BC-breaking, it would be great to see a more thorough writeup in the PR summary of why we want this and how this fits into the overall strategy of torchao.
Yes, this PR is still a work in progress. Will add a thorough write-up |
Float8Tensor, a new subclass for float8, independent of AQT. It's a BC breaking change, hence will need to proceed with it, by deprecating the current API, and issuing a user warning about the deprecation. The new API will be available to users for use. After a substancial amount of time, once we know user has replaced the deprecated API with the updated one, we can delete it's code
Stack from ghstack (oldest at bottom):