Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ukernel selection logic + clean up KleidiAI integration #1652

Merged
merged 2 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/torchao_experimental_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,22 @@ jobs:
pip install numpy
pip install pytest
USE_CPP=1 pip install .
- name: Run tests
- name: Run python tests
run: |
conda activate venv
pytest torchao/experimental/tests/test_int8_dynamic_activation_intx_weight.py
python torchao/experimental/tests/test_embedding_xbit_quantizer.py
- name: Run kernels/cpu/aarch64/tests
run: |
conda activate venv
pushd torchao/experimental/kernels/cpu/aarch64/tests
sh build_and_run_tests.sh
rm -rf /tmp/cmake-out
popd
- name: Run torchao/experimental/ops/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

run: |
conda activate venv
pushd torchao/experimental/ops/tests
sh build_and_run_tests.sh
rm -rf /tmp/cmake-out
popd
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def build_cmake(self, ext):
"cmake",
ext.sourcedir,
"-DCMAKE_BUILD_TYPE=" + build_type,
"-DTORCHAO_BUILD_EXECUTORCH_OPS=OFF",
# Disable now because 1) KleidiAI increases build time, and 2) KleidiAI has accuracy issues due to BF16
"-DTORCHAO_BUILD_KLEIDIAI=OFF",
"-DTorch_DIR=" + torch_dir,
"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=" + extdir,
],
Expand Down

This file was deleted.

This file was deleted.

Loading
Loading