Attempt to switch everything to cmake #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #1659, branch: drisspg/stack/33
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1659
Note: Links to docs will display an error until the docs builds have been completed. ❌ 23 New Failures, 2 Unrelated FailuresAs of commit 1564578 with merge base 6ffe236 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
force-pushed
the
drisspg/stack/33
branch
from
27274cc to
1564578
Compare
facebook-github-bot
added
the
CLA Signed
ngc92
reviewed
Feb 16, 2025
|
|
||
| # CUDA Setup | ||
| if(CMAKE_CUDA_COMPILER) | ||
| enable_language(CUDA) |
There was a problem hiding this comment.
isn't this redundant with setting CUDA in project?
|
|
||
| # Set CUDA architectures if not already set | ||
| if(NOT DEFINED CMAKE_CUDA_ARCHITECTURES) | ||
| set(CMAKE_CUDA_ARCHITECTURES 70 75 80 86) |
| # Set CUDA flags | ||
| # Set CUDA architectures and TORCH_CUDA_ARCH_LIST | ||
| if(NOT DEFINED TORCH_CUDA_ARCH_LIST) | ||
| set(TORCH_CUDA_ARCH_LIST "7.0;7.5;8.0;8.6;9.0") |
| if(CMAKE_BUILD_TYPE STREQUAL "Debug") | ||
| add_compile_options(-g -O0) | ||
| if(CMAKE_CUDA_COMPILER) | ||
| add_compile_options($<$<COMPILE_LANGUAGE:CUDA>:-g>) |
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}) | ||
|
|
||
| # CUDA Setup | ||
| if(CMAKE_CUDA_COMPILER) |
There was a problem hiding this comment.
what happens if python sets -DUSE_CUDA=OFF, but cmake finds cuda, or the other way around?
| ) | ||
|
|
||
| # Set Python limited API version | ||
| target_compile_definitions(torchao_core PRIVATE Py_LIMITED_API=0x03090000) |
There was a problem hiding this comment.
Py_LIMITED_API is already set for all targets somewhere above
|
cc @drisspg are you still planning on working on this? |
|
nope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Attempt to switch everything to cmake