mx formats: create MXLinearConfig #1688
Open
+91
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1688
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1064e83 with merge base d3306b2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Feb 10, 2025
Summary: Creating a config to make it easier to enable more configuration options. This is important as we enable more functionality from pytorch/pytorch#146414 in torchao. Note that future PRs will flesh out the config, to keep PR size small. Test Plan: ``` pytest test/prototype/mx_formats/ -s -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d6b63187f87dee1467ba2a6377863023df7d9f6f ghstack-comment-id: 2648821215 Pull Request resolved: #1688
vkuzo
added
the
topic: not user facing
danielvegamyhre
approved these changes
Feb 13, 2025
| x_mx_dq = to_dtype( | ||
| x_mx._data, | ||
| x_mx._scale_e8m0, | ||
| x_mx._elem_dtype, | ||
| x_mx._block_size, | ||
| hp_dtype, # noqa: E501 | ||
| use_fp4_custom_triton_dequant_kernel, |
There was a problem hiding this comment.
Why is this needed? I did a quick pass through the RFC and didn't see any reference to this functionality
There was a problem hiding this comment.
we'll probably delete it in a future PR. The current PR is a refactor with no logic changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Creating a config to make it easier to enable more configuration
options. This is important as we enable more functionality from
pytorch/pytorch#146414 in torchao.
Note that future PRs will flesh out the config, to keep PR size small.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: