Remove libOMP linking for experimental kernels #1822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1822
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@metascroy @manuelcandales Is there CI that auto checks for this? How should we test this? Edit: Hmmm interesting, Run TorchAO Experimental Tests / test (macos-14) passed on main |
|
It looks like it fails with linking error if you don't make it explicit. It might have to do with the version of pytorch being used in the test. Do you know which version has OMP bundled? |
|
I think you're right, it was updated circa pytorch/pytorch#145870 I'll bump the pinned PT |
jcaip
approved these changes
Mar 4, 2025
* CPUOffload: only offload parameters above a certain size * lint * ruff --------- Co-authored-by: Mark Saroufim <[email protected]>
* update typehint Signed-off-by: Masaki Kozuki <[email protected]> * Update float8_linear_utils.py --------- Signed-off-by: Masaki Kozuki <[email protected]> Co-authored-by: Mark Saroufim <[email protected]>
* Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned] * Update [ghstack-poisoned]
* init * up * up * up * up * up * up * up * up * up
|
Remade PR: #1828 This one got flooded on a bad rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in pytorch/torchchat#1493, we no longer need to explicitly link to OMP libs