Skip to content

integrate mx dim1 triton kernel into MXLinear #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 27, 2025
Merged

integrate mx dim1 triton kernel into MXLinear #1943

merged 16 commits into from
Mar 27, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 24, 2025

Summary:

Adds a config option to MXLinear to use a triton kernel for mxfp8 cast
across dim1.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 14 commits March 21, 2025 06:59
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1943

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f245d64 with merge base d32afef (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2025
vkuzo added a commit that referenced this pull request Mar 24, 2025
Summary:

Adds a config option to MXLinear to use a triton kernel for mxfp8 cast
across dim1.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a1bfdcd
ghstack-comment-id: 2748987830
Pull Request resolved: #1943
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 24, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 24, 2025
Summary:

Adds a config option to MXLinear to use a triton kernel for mxfp8 cast
across dim1.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 05a1ae0
ghstack-comment-id: 2748987830
Pull Request resolved: #1943
[ghstack-poisoned]
@vkuzo vkuzo merged commit fc42ecb into main Mar 27, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants