Skip to content

mx: temporarily disable the rceil tests #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Apr 1, 2025
Merged

mx: temporarily disable the rceil tests #1977

merged 59 commits into from
Apr 1, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 28, 2025

Summary:

  1. the PR that added this test was landed after
    use torch.float8_e8m0fnu in mx_formats #1966, so updating to use e8m0fnu
  2. the tests are not passing on my B200, so skipping for now to keep
    local CI clean for upcoming branch cut

We should figure out what is wrong here and reenable at a future time.

Test Plan:

pytest test/prototype/mx_formats/ -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 30 commits March 21, 2025 06:59
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vkuzo added 4 commits March 28, 2025 07:12
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 28, 2025

Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1977

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 1 Pending, 1 Unrelated Failure

As of commit a62e00b with merge base 42e1345 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
vkuzo added a commit that referenced this pull request Mar 28, 2025
Summary:

1. the PR that added this test was landed after
   #1966, so updating to use e8m0fnu
2. the tests are not passing on my B200, so skipping for now to keep
   local CI clean for upcoming branch cut

We should figure out what is wrong here and reenable at a future time.

Test Plan:

```
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 70a1abf
ghstack-comment-id: 2761624330
Pull Request resolved: #1977
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 28, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 28, 2025
Summary:

1. the PR that added this test was landed after
   #1966, so updating to use e8m0fnu
2. the tests are not passing on my B200, so skipping for now to keep
   local CI clean for upcoming branch cut

We should figure out what is wrong here and reenable at a future time.

Test Plan:

```
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6a2f467
ghstack-comment-id: 2761624330
Pull Request resolved: #1977
vkuzo added 10 commits March 28, 2025 13:00
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/83/head to main March 28, 2025 20:03
@vkuzo vkuzo merged commit 7d110e2 into main Apr 1, 2025
44 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants