add PyTorch MG style group gemm reference utils #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1979
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b5fa626 with merge base 3766ed7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lessw2020
added
numerics
topic: not user facing
Contributor
|
LGTM, will leave approval for @vkuzo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a single reference file for computing forward and backward (dx, dw) results for MG style group gemms.
It uses PyTorch directly via manual looping and PyTorch Autograd to compute reference values to be used in verifying other (Triton, torch.compile) group Gemm results.
The idea here is for both fp8 and bf16 group gemms to use the same reference generation to ensure consistent unit testing.