Skip to content

Model shapes config #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: bench-gpu-profiling
Choose a base branch
from
Open

Model shapes config #2036

wants to merge 5 commits into from

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Apr 10, 2025 •
edited
Loading

Adds support for more models and shapes configurations in benchmarking framework.

TODO: Add more stuff here

Follow PR: #2032

@jainapurva jainapurva requested a review from Copilot April 10, 2025 19:18
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2036

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7677902 with merge base 9516764 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2025
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

@jainapurva jainapurva added the topic: performance Use this tag if this PR improves the performance of a feature label Apr 10, 2025
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

@jainapurva jainapurva force-pushed the model_shapes_config branch from bcdb20c to bbcba36 Compare April 10, 2025 23:12
@jainapurva jainapurva marked this pull request as ready for review April 14, 2025 19:34
HDCharles
HDCharles reviewed Apr 15, 2025
View reviewed changes
torchao/testing/model_architectures.py
import torch.nn as nn


class ToyLinearModel(torch.nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you plan to use these for benchmarks they should be in torchao rather than testing. I think if someone pip installs torchao it doesn't install the test dir.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should probably mark as a TODO to conslidate all random model architecture definitions into one place. ToyLinear shows up all over hte place in our testing code.

@HDCharles
Copy link
Contributor

it looks like htere's more here than just model shapes config, should add more documentaiton to PR description about all the things that are being changed/updated.

HDCharles
HDCharles requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything expected to be used outside of tests should be in ao. imports in benchmarks to testing should have a really good justification.

@jainapurva jainapurva changed the base branch from main to bench-gpu-profiling April 15, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@HDCharles HDCharles HDCharles requested changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@drisspg drisspg Awaiting requested review from drisspg

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: performance Use this tag if this PR improves the performance of a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jainapurva @HDCharles @facebook-github-bot