Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reland][ROCm] preshuffled weight mm #2044

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

jeffdaily
Copy link
Contributor

Adds SwizzleTensor subclass that wraps a Tensor and reorders the contents to be suitable for HIPBLASLT_ORDER_COL16_4R8. SwizzleTensor intercepts torch.mm and replaces with custom calls to hipblaslt.

Copy link

pytorch-bot bot commented Apr 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2044

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit 53000ac with merge base a81322e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@jeffdaily
Copy link
Contributor Author

@mxz297 @jerryzh168 please re-review, kick of CI, thanks.

@mxz297
Copy link

mxz297 commented Apr 13, 2025

@jeffdaily "test-mps-ops" still seems to be failing to compile with

  /Users/ec2-user/runner/_work/ao/ao/torchao/csrc/rocm/swizzle/swizzle.cpp:1:10: fatal error: 'hip/hip_runtime.h' file not found
  #include <hip/hip_runtime.h>
           ^~~~~~~~~~~~~~~~~~~

I wonder if we should just guard the whole source file under #if USE_ROCM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants